Skip to content

Model changes from 20230412 discussion #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 1, 2023
Merged

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (474ae2e) 97.28% compared to head (a381481) 97.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3082      +/-   ##
==========================================
- Coverage   97.28%   97.18%   -0.10%     
==========================================
  Files         222      222              
  Lines       44085    44090       +5     
==========================================
- Hits        42887    42848      -39     
- Misses       1198     1242      +44     
Flag Coverage Δ
linux 97.18% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormlib/gen.py 100.00% <ø> (ø)
synapse/models/dns.py 100.00% <ø> (ø)
synapse/models/inet.py 99.25% <ø> (ø)
synapse/models/infotech.py 98.66% <ø> (ø)
synapse/models/orgs.py 100.00% <ø> (ø)
synapse/models/person.py 100.00% <ø> (ø)
synapse/models/risk.py 100.00% <ø> (ø)
synapse/cortex.py 96.83% <100.00%> (-0.52%) ⬇️
synapse/lib/modelrev.py 98.08% <100.00%> (+0.02%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th changed the title WIP: model changes from 20230412 discussion Model changes from 20230412 discussion May 1, 2023
mbvertex
mbvertex previously approved these changes May 1, 2023
Copy link
Contributor

@therealsilence therealsilence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things

@invisig0th invisig0th merged commit 56f71f5 into master May 1, 2023
@invisig0th invisig0th deleted the visi-model-20230412 branch May 1, 2023 19:57
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants