Skip to content

Update axon to always pass size when saving (SYN-3938) #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Apr 14, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (53d207c) 97.27% compared to head (6d417ac) 97.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3084      +/-   ##
==========================================
- Coverage   97.27%   97.17%   -0.11%     
==========================================
  Files         222      222              
  Lines       44029    44028       -1     
==========================================
- Hits        42829    42783      -46     
- Misses       1200     1245      +45     
Flag Coverage Δ
linux 97.17% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/axon.py 98.47% <100.00%> (-0.15%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Cisphyx Cisphyx merged commit 9292576 into master Apr 17, 2023
@Cisphyx Cisphyx deleted the axon-size branch April 17, 2023 14:45
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants