Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing toprim checks on storm rule apis (SYN-5267) #3086

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added the bug label Apr 17, 2023
@vEpiphyte vEpiphyte added this to the v2.12x.x milestone Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +6.40 🎉

Comparison is base (e644508) 90.76% compared to head (65e44b3) 97.17%.

❗ Current head 65e44b3 differs from pull request most recent head 0c47f1a. Consider uploading reports for the commit 0c47f1a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
+ Coverage   90.76%   97.17%   +6.40%     
==========================================
  Files         222      222              
  Lines       44028    44034       +6     
==========================================
+ Hits        39964    42789    +2825     
+ Misses       4064     1245    -2819     
Flag Coverage Δ
linux 97.17% <100.00%> (+10.14%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormtypes.py 98.75% <100.00%> (+0.02%) ⬆️

... and 61 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit 26c971e into master Apr 17, 2023
@vEpiphyte vEpiphyte deleted the bug_setrules_toprim branch May 1, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants