Skip to content

Prevent zero-length tag lifts, norm tag names more consistently (SYN-5190, SYN-5289) #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 30, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Apr 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (af1f6f0) 97.31% compared to head (e49fbda) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
- Coverage   97.31%   97.21%   -0.10%     
==========================================
  Files         223      223              
  Lines       44433    44451      +18     
==========================================
- Hits        43240    43215      -25     
- Misses       1193     1236      +43     
Flag Coverage Δ
linux 97.21% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/parser.py 98.51% <ø> (-0.11%) ⬇️
synapse/lib/storm_format.py 100.00% <ø> (ø)
synapse/lib/ast.py 98.91% <100.00%> (+0.05%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added the bug label Apr 19, 2023
@vEpiphyte vEpiphyte modified the milestone: v2.1xx.x Apr 19, 2023
@Cisphyx Cisphyx changed the title Prevent zero-length tag lifts (SYN-5190) WIP: Prevent zero-length tag lifts (SYN-5190) Apr 28, 2023
@Cisphyx Cisphyx changed the title WIP: Prevent zero-length tag lifts (SYN-5190) Prevent zero-length tag lifts, norm tag names more consistently (SYN-5190, SYN-5289) May 8, 2023
@Cisphyx Cisphyx changed the title Prevent zero-length tag lifts, norm tag names more consistently (SYN-5190, SYN-5289) WIP: Prevent zero-length tag lifts, norm tag names more consistently (SYN-5190, SYN-5289) May 9, 2023
@Cisphyx Cisphyx changed the title WIP: Prevent zero-length tag lifts, norm tag names more consistently (SYN-5190, SYN-5289) Prevent zero-length tag lifts, norm tag names more consistently (SYN-5190, SYN-5289) May 9, 2023
@invisig0th invisig0th merged commit f13d939 into master May 30, 2023
@invisig0th invisig0th deleted the emptytag-bug branch May 30, 2023 18:41
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants