Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting props using Storm NodeProps prim (SYN-5206, SYN-5295) #3098

Merged
merged 10 commits into from
Apr 24, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Apr 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (ed7888f) 97.27% compared to head (c30e149) 97.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   97.27%   97.17%   -0.11%     
==========================================
  Files         222      222              
  Lines       44051    44057       +6     
==========================================
- Hits        42851    42812      -39     
- Misses       1200     1245      +45     
Flag Coverage Δ
linux 97.17% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/ast.py 98.79% <100.00%> (+<0.01%) ⬆️
synapse/lib/stormtypes.py 98.75% <100.00%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Cisphyx Cisphyx changed the title Add del method to Storm NodeProps prims (SYN-5206) Add del method to Storm NodeProps prims (SYN-5206, SYN-5295) Apr 24, 2023
@Cisphyx Cisphyx changed the title Add del method to Storm NodeProps prims (SYN-5206, SYN-5295) Allow deleting props using Storm NodeProps prim (SYN-5206, SYN-5295) Apr 24, 2023
@vEpiphyte vEpiphyte added this to the v2.1xx.x milestone Apr 24, 2023
@Cisphyx Cisphyx merged commit 5ece0ad into master Apr 24, 2023
@Cisphyx Cisphyx deleted the node-propdel branch April 24, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants