Stormlib type introspection (SYN-2367) #3100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3100 +/- ##
==========================================
+ Coverage 96.90% 97.21% +0.31%
==========================================
Files 226 226
Lines 45234 45254 +20
==========================================
+ Hits 43832 43992 +160
+ Misses 1402 1262 -140
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
invisig0th
requested changes
Apr 26, 2023
|
|
||
| Args: | ||
| valu: The object to check. | ||
| basetypes (bool): If True, return the base Python class name as a fallback. |
There was a problem hiding this comment.
I don't want to expose this option :)
There was a problem hiding this comment.
I don't expose it for storm users. There is a use case for this internally though in #3097
vEpiphyte
changed the title
vEpiphyte
changed the title
Cisphyx
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.