Skip to content

Initialize layer slabs before opening in readonly mode #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 26, 2023
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Apr 25, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (1308584) 97.27% compared to head (6882b85) 97.18%.

❗ Current head 6882b85 differs from pull request most recent head 3f2617b. Consider uploading reports for the commit 3f2617b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   97.27%   97.18%   -0.10%     
==========================================
  Files         222      222              
  Lines       44057    44065       +8     
==========================================
- Hits        42857    42823      -34     
- Misses       1200     1242      +42     
Flag Coverage Δ
linux 97.18% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/layer.py 96.61% <100.00%> (-0.03%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Cisphyx Cisphyx changed the title Check for attempts to add invalid layer defs Initialize layer slabs before opening in readonly mode Apr 26, 2023
vEpiphyte
vEpiphyte previously approved these changes Apr 26, 2023
@Cisphyx Cisphyx merged commit 6d6ec68 into master Apr 26, 2023
@Cisphyx Cisphyx deleted the badlayr-defs branch April 26, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants