Skip to content

Uniq nodes in multilayer prop lifts (SYN-5174, SYN-5160) #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2023
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Apr 26, 2023

No description provided.

@Cisphyx Cisphyx changed the title Uniq nodes in multilayer prop lifts (SYN-5174, 5160) Uniq nodes in multilayer prop lifts (SYN-5174, SYN-5160) Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.12 ⚠️

Comparison is base (e49f13f) 97.28% compared to head (d990e78) 97.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3110      +/-   ##
==========================================
- Coverage   97.28%   97.16%   -0.12%     
==========================================
  Files         222      222              
  Lines       44065    44085      +20     
==========================================
- Hits        42867    42835      -32     
- Misses       1198     1250      +52     
Flag Coverage Δ
linux 97.16% <100.00%> (+0.05%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 96.83% <100.00%> (-0.51%) ⬇️
synapse/lib/ast.py 98.79% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@invisig0th invisig0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on the lift by data use case!

@Cisphyx Cisphyx added the reqChangelog requires changelog label Apr 28, 2023
@Cisphyx Cisphyx added this to the v2.13x.x milestone Apr 28, 2023
@Cisphyx Cisphyx merged commit 9d0f2c7 into master Apr 28, 2023
@Cisphyx Cisphyx deleted the dupelift-fix branch April 28, 2023 15:22
@vEpiphyte vEpiphyte added bug and removed reqChangelog requires changelog labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants