Skip to content

Add getScopeVars to storm runtime and use for background scope #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added this to the v2.132.0 milestone May 3, 2023
@vEpiphyte vEpiphyte added the bug label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -3.55 ⚠️

Comparison is base (9206998) 97.29% compared to head (1a508e4) 93.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3120      +/-   ##
==========================================
- Coverage   97.29%   93.74%   -3.55%     
==========================================
  Files         222      222              
  Lines       44134    44140       +6     
==========================================
- Hits        42939    41378    -1561     
- Misses       1195     2762    +1567     
Flag Coverage Δ
linux 93.74% <100.00%> (-3.45%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.76% <100.00%> (-0.07%) ⬇️

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit b89d66d into master May 3, 2023
@vEpiphyte vEpiphyte deleted the visi-background-scope branch May 3, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants