Skip to content

Ensure/allow callers to specify iden for adding triggers and dmons (SYN-5334) #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@invisig0th invisig0th changed the title Ensure/allow callers to specify iden for adding triggers and dmons Ensure/allow callers to specify iden for adding triggers and dmons (SYN-5334) May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (f4ea964) 97.28% compared to head (9995ed2) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3121      +/-   ##
==========================================
- Coverage   97.28%   97.19%   -0.10%     
==========================================
  Files         222      222              
  Lines       44164    44174      +10     
==========================================
- Hits        42967    42933      -34     
- Misses       1197     1241      +44     
Flag Coverage Δ
linux 97.19% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 96.87% <100.00%> (-0.52%) ⬇️
synapse/lib/stormtypes.py 98.75% <100.00%> (+<0.01%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 4, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels May 4, 2023
@invisig0th invisig0th requested a review from vEpiphyte May 5, 2023 08:58
@vEpiphyte vEpiphyte merged commit 5972a0f into master May 8, 2023
@vEpiphyte vEpiphyte deleted the visi-specify-idens branch May 8, 2023 13:31
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants