Skip to content

Allow aha provisioning tools to emit only the URL (SYN-5301) #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels May 5, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (5972a0f) 97.29% compared to head (afb1aa0) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.10%     
==========================================
  Files         222      222              
  Lines       44174    44188      +14     
==========================================
- Hits        42977    42950      -27     
- Misses       1197     1238      +41     
Flag Coverage Δ
linux 97.19% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/tools/aha/provision/service.py 97.91% <100.00%> (+8.17%) ⬆️
synapse/tools/aha/provision/user.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th
Copy link
Contributor

Would it be worth discussing just making this be how the tool operates by default?

Copy link
Contributor

@invisig0th invisig0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should just make this be how it works by default?

@vEpiphyte
Copy link
Contributor Author

discussed question; going to leave the current behavior in place.

@vEpiphyte vEpiphyte merged commit 7585266 into master May 8, 2023
@vEpiphyte vEpiphyte deleted the feat_aha_prov_urls branch May 8, 2023 16:45
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants