Add --forms arg to scrape, adjust ftp fang regex (SYN-5266, SYN-5234, SYN-5302) #3127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3127 +/- ##
==========================================
+ Coverage 96.70% 97.19% +0.48%
==========================================
Files 222 222
Lines 44272 44292 +20
==========================================
+ Hits 42814 43050 +236
+ Misses 1458 1242 -216
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
vEpiphyte
reviewed
May 8, 2023
| msgs = await core.stormlist('[ media:news=* :title="https://t.c\\\\" ] | scrape :title') | ||
| self.stormIsInWarn('BadTypeValue', msgs) | ||
| self.stormHasNoWarnErr(msgs) |
There was a problem hiding this comment.
we'll need to note the lack of warnings for bad values now
invisig0th
requested changes
May 10, 2023
vEpiphyte
previously approved these changes
May 11, 2023
invisig0th
requested changes
May 15, 2023
| refang = await s_stormtypes.tobool(self.opts.dorefang) | ||
|
|
||
| if not isinstance(forms, (tuple, list, set)): | ||
| forms = (forms,) |
There was a problem hiding this comment.
Lets also add a split on , here so --forms foo:bar,baz:faz works too 👍
invisig0th
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.