Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional layer validation in view schema (SYN-5335) #3128

Merged
merged 2 commits into from
May 8, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented May 8, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (5972a0f) 97.29% compared to head (c72e362) 97.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3128      +/-   ##
==========================================
- Coverage   97.29%   97.18%   -0.11%     
==========================================
  Files         222      222              
  Lines       44174    44174              
==========================================
- Hits        42977    42930      -47     
- Misses       1197     1244      +47     
Flag Coverage Δ
linux 97.18% <ø> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/view.py 97.04% <ø> (-0.33%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels May 8, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 8, 2023
@Cisphyx Cisphyx merged commit 92dbb39 into master May 8, 2023
@Cisphyx Cisphyx deleted the view-schema-layrs branch May 8, 2023 15:07
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants