Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct storm texthash, add docs (SYN-5383, SYN-5388) #3130

Merged
merged 3 commits into from
May 9, 2023
Merged

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

Copy link
Contributor

@invisig0th invisig0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we wanna stop stripping whitespace from query text input? Shouldn't matter at all :)

CHANGELOG.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (eafb847) 97.29% compared to head (181348c) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3130      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.10%     
==========================================
  Files         222      222              
  Lines       44200    44200              
==========================================
- Hits        43006    42962      -44     
- Misses       1194     1238      +44     
Flag Coverage Δ
linux 97.19% <100.00%> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/parser.py 98.61% <100.00%> (ø)
synapse/lib/view.py 97.04% <100.00%> (-0.33%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte
Copy link
Contributor Author

I captured the question about whitespace removal to have that as a separate discussion.

@vEpiphyte vEpiphyte merged commit ca4c46d into master May 9, 2023
@vEpiphyte vEpiphyte deleted the bug_texthash branch May 9, 2023 19:38
@vEpiphyte vEpiphyte modified the milestones: v2.13x.x, v2.133.1 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants