Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view.set() for parents (SYN-5392) #3131

Merged
merged 2 commits into from
May 10, 2023
Merged

Fix view.set() for parents (SYN-5392) #3131

merged 2 commits into from
May 10, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added the bug label May 10, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (b91e8b5) 97.29% compared to head (ee40dce) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.10%     
==========================================
  Files         222      222              
  Lines       44200    44200              
==========================================
- Hits        43006    42962      -44     
- Misses       1194     1238      +44     
Flag Coverage Δ
linux 97.19% <100.00%> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/view.py 97.04% <100.00%> (-0.33%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit f40130c into master May 10, 2023
@vEpiphyte vEpiphyte deleted the bug_setview_parent branch May 10, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants