Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getTypeDef for basic types (SYN-5327) #3139

Merged
merged 6 commits into from
May 17, 2023
Merged

Fix getTypeDef for basic types (SYN-5327) #3139

merged 6 commits into from
May 17, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented May 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (b3557bf) 97.30% compared to head (d2464e4) 97.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3139      +/-   ##
==========================================
- Coverage   97.30%   97.20%   -0.10%     
==========================================
  Files         222      222              
  Lines       44327    44327              
==========================================
- Hits        43133    43089      -44     
- Misses       1194     1238      +44     
Flag Coverage Δ
linux 97.20% <100.00%> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/types.py 97.62% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 17, 2023
@vEpiphyte vEpiphyte added the bug label May 17, 2023
@Cisphyx Cisphyx merged commit 8a6543a into master May 17, 2023
@Cisphyx Cisphyx deleted the basetype-defs branch May 17, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants