Skip to content

Move the cell.guid copy into cell.py (SYN-5292) #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2023

Conversation

vEpiphyte
Copy link
Contributor

ensure that the backup cell.guid file is made before we start the backup process

@vEpiphyte vEpiphyte added the bug label May 17, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.55 ⚠️

Comparison is base (16824f1) 96.54% compared to head (cc40afa) 92.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3145      +/-   ##
==========================================
- Coverage   96.54%   92.00%   -4.55%     
==========================================
  Files         222      222              
  Lines       44328    44329       +1     
==========================================
- Hits        42798    40785    -2013     
- Misses       1530     3544    +2014     
Flag Coverage Δ
linux 92.00% <100.00%> (+3.40%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/tools/backup.py 99.00% <ø> (-0.01%) ⬇️
synapse/lib/cell.py 97.39% <100.00%> (-0.49%) ⬇️

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte requested a review from Cisphyx May 17, 2023 21:39
@vEpiphyte vEpiphyte added the reqChangelog requires changelog label May 17, 2023
@vEpiphyte vEpiphyte merged commit e27dc56 into master May 18, 2023
@vEpiphyte vEpiphyte deleted the del-partial-backups-v2 branch May 18, 2023 01:31
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants