Skip to content

Fix perms check on runas command to allow elevated storm runtimes #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (92985ad) 97.30% compared to head (4a4feca) 97.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
- Coverage   97.30%   97.20%   -0.10%     
==========================================
  Files         222      222              
  Lines       44335    44335              
==========================================
- Hits        43141    43097      -44     
- Misses       1194     1238      +44     
Flag Coverage Δ
linux 97.20% <100.00%> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.90% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th merged commit 56f2023 into master May 22, 2023
@invisig0th invisig0th deleted the bug-runas-perms branch May 22, 2023 13:40
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 23, 2023
@vEpiphyte vEpiphyte added the bug label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants