Skip to content

Move core permdefs into their own init function, ensure the pdefs are validated #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (336b898) 97.31% compared to head (6954003) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3154      +/-   ##
==========================================
- Coverage   97.31%   97.21%   -0.10%     
==========================================
  Files         222      222              
  Lines       44352    44360       +8     
==========================================
- Hits        43159    43123      -36     
- Misses       1193     1237      +44     
Flag Coverage Δ
linux 97.21% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 95.90% <ø> (ø)
synapse/cortex.py 96.87% <100.00%> (-0.51%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th merged commit 7575a93 into master May 24, 2023
@invisig0th invisig0th deleted the feat_permdefs_onload branch May 24, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants