Skip to content

Remove trailing . when repr()ing a taxon and lower case bool repr #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 31, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added this to the v2.13x.x milestone May 26, 2023
@invisig0th invisig0th changed the title remove trailing . when repr()ing a taxon and lower case bool repr WIP: remove trailing . when repr()ing a taxon and lower case bool repr May 26, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (f13d939) 97.31% compared to head (cc9caba) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
- Coverage   97.31%   97.21%   -0.10%     
==========================================
  Files         223      223              
  Lines       44451    44453       +2     
==========================================
- Hits        43259    43217      -42     
- Misses       1192     1236      +44     
Flag Coverage Δ
linux 97.21% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/types.py 97.62% <100.00%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th changed the title WIP: remove trailing . when repr()ing a taxon and lower case bool repr Remove trailing . when repr()ing a taxon and lower case bool repr May 31, 2023
@invisig0th invisig0th merged commit 37336ed into master May 31, 2023
@invisig0th invisig0th deleted the visi-taxon-repr branch May 31, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants