Add $lib.auth.easyperm and $user.vars (SYN-5278) #3167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3167 +/- ##
==========================================
- Coverage 97.31% 97.22% -0.10%
==========================================
Files 223 224 +1
Lines 44469 44547 +78
==========================================
+ Hits 43277 43311 +34
- Misses 1192 1236 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
… into lib-easyperm
vEpiphyte
reviewed
Jun 2, 2023
vEpiphyte
reviewed
Jun 2, 2023
vEpiphyte
reviewed
Jun 2, 2023
vEpiphyte
reviewed
Jun 2, 2023
vEpiphyte
reviewed
Jun 2, 2023
invisig0th
reviewed
Jun 2, 2023
synapse/lib/cell.py
Outdated
| @@ -2228,6 +2228,22 @@ async def popUserProfInfo(self, iden, name, default=None): | |||
| user = await self.auth.reqUser(iden) | |||
| return await user.profile.pop(name, default=default) | |||
|
|
|||
| async def getUserVars(self, iden): | |||
| user = await self.auth.reqUser(iden) | |||
| return user.vars.pack() | |||
There was a problem hiding this comment.
Do we maybe want to make this a tuple yielder to account for eventually not having them in the hive and potential user var growth?
There was a problem hiding this comment.
updated to iterUserVars
invisig0th
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.