SYN-5470 Implement modulo operator for storm #3168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 2, 2023
ghost
commented
- Fixes SYN-5470
- Update grammar to include modulo operator (%)
- Update AST to handle module
- Update stormtypes.Number to have dunders for mod operations
- Update tests to include modulo checks and precedence WRT other math operations
- Fixes SYN-5470 - Update grammar to include modulo operator (%) - Update AST to handle module - Update stormtypes.Number to have dunders for mod operations - Update tests to include modulo checks and precedence WRT other math operations
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
- Coverage 97.31% 97.22% -0.10%
==========================================
Files 223 223
Lines 44454 44469 +15
==========================================
- Hits 43262 43233 -29
- Misses 1192 1236 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
- Update changelog
ghost
changed the title
|
I didn't see any documentation on the existing math operations. If I just missed it, let me know and I'll update it as needed. |
ghost
marked this pull request as ready for review
ghost
changed the title
invisig0th
requested changes
Jun 2, 2023
invisig0th
reviewed
Jun 2, 2023
Cisphyx
reviewed
Jun 2, 2023
Cisphyx
reviewed
Jun 2, 2023
Cisphyx
reviewed
Jun 2, 2023
Cisphyx
reviewed
Jun 2, 2023
ghost
force-pushed
the
blackout/storm-modulo-support
branch
from
d44fde3 to
765c86a
Compare
invisig0th
approved these changes
Jun 5, 2023
|
I'd like one more pass from cisphyx before this gets merged, but looking great! |
Cisphyx
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.