Skip to content

Easy model changes from 2023-05-09+ batch #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 8, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.12 ⚠️

Comparison is base (bd33b91) 97.33% compared to head (32e38be) 97.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3169      +/-   ##
==========================================
- Coverage   97.33%   97.22%   -0.12%     
==========================================
  Files         224      224              
  Lines       44762    44788      +26     
==========================================
- Hits        43570    43543      -27     
- Misses       1192     1245      +53     
Flag Coverage Δ
linux 97.22% <100.00%> (-0.02%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/models/base.py 100.00% <ø> (ø)
synapse/models/geopol.py 100.00% <ø> (ø)
synapse/models/geospace.py 98.38% <ø> (ø)
synapse/models/infotech.py 98.66% <ø> (ø)
synapse/models/orgs.py 100.00% <ø> (ø)
synapse/models/risk.py 100.00% <ø> (ø)
synapse/models/transport.py 100.00% <ø> (ø)
synapse/lib/layer.py 96.62% <100.00%> (-0.04%) ⬇️
synapse/lib/modelrev.py 98.20% <100.00%> (+0.10%) ⬆️
synapse/models/inet.py 99.25% <100.00%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mbvertex mbvertex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo

mbvertex
mbvertex previously approved these changes Jun 5, 2023
@invisig0th invisig0th requested review from vEpiphyte and mbvertex June 6, 2023 11:27
mbvertex
mbvertex previously approved these changes Jun 6, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone Jun 6, 2023
@invisig0th invisig0th requested a review from vEpiphyte June 7, 2023 14:26
Cisphyx
Cisphyx previously approved these changes Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants