VS-326/SYN-5379: Update $lib.infosec.cvss.calculate to support new CVSS props schemas and calculating v2.0 and v3.0 scores #3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 7, 2023
ghost
commented
- Added vectToScore which includes support for CVSS2, CVSS3.0, and CVSS3.1
- Added tests for new code
ghost
commented
Jun 7, 2023
invisig0th
requested changes
Jun 7, 2023
invisig0th
reviewed
Jun 7, 2023
ghost
marked this pull request as ready for review
invisig0th
requested changes
Jun 7, 2023
|
( oh, and the CI issue obvs :D ) |
- Added vectToScore which includes support for CVSS2, CVSS3.0, and CVSS3.1 - Added tests for new code
ghost
force-pushed
the
blackout/VS-326/cvss-vectToScore
branch
from
0fd68f9 to
b53da79
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3171 +/- ##
==========================================
- Coverage 97.32% 97.23% -0.09%
==========================================
Files 224 224
Lines 44549 44762 +213
==========================================
+ Hits 43357 43526 +169
- Misses 1192 1236 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
- Added a couple vectors to get some edge cases in the code coverage - Updated CVSS2 calculations to distinguish None temporal scores vs 0.0
ghost
changed the title
invisig0th
approved these changes
Jun 8, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.