Skip to content

SYN-5544: $lib.print($lib.cast(str, (5.3 / 2))) produces BadTypeValu: no norm for type: <class 'float'>. #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
7 commits merged into from
Jun 14, 2023
Merged

SYN-5544: $lib.print($lib.cast(str, (5.3 / 2))) produces BadTypeValu: no norm for type: <class 'float'>. #3174

7 commits merged into from
Jun 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 8, 2023

  • Add norm callback for float to Str type

@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (54d2d7e) 97.34% compared to head (1e320b0) 97.24%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
- Coverage   97.34%   97.24%   -0.10%     
==========================================
  Files         224      224              
  Lines       44836    44840       +4     
==========================================
- Hits        43644    43604      -40     
- Misses       1192     1236      +44
Flag Coverage Δ
linux 97.24% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/types.py 97.63% <100.00%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost changed the title SYN-5544: $lib.print($lib.cast(str, (5.3 / 2))) produces BadTypeValu: no norm for type: <class 'float'>. WIP: SYN-5544: $lib.print($lib.cast(str, (5.3 / 2))) produces BadTypeValu: no norm for type: <class 'float'>. Jun 8, 2023
@ghost ghost changed the title WIP: SYN-5544: $lib.print($lib.cast(str, (5.3 / 2))) produces BadTypeValu: no norm for type: <class 'float'>. SYN-5544: $lib.print($lib.cast(str, (5.3 / 2))) produces BadTypeValu: no norm for type: <class 'float'>. Jun 13, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone Jun 13, 2023
vEpiphyte
vEpiphyte previously approved these changes Jun 13, 2023
View reviewed changes
@ghost ghost force-pushed the blackout/SYN-5544/str-casted-float branch from b1d621c to 5e2157d Compare June 13, 2023 20:04
@ghost ghost requested a review from vEpiphyte June 13, 2023 21:18
@vEpiphyte vEpiphyte added the reqChangelog requires changelog label Jun 14, 2023
@ghost ghost merged commit dd084b6 into master Jun 14, 2023
@ghost ghost deleted the blackout/SYN-5544/str-casted-float branch June 14, 2023 15:59
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 7, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2.139.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Cisphyx @vEpiphyte @MichaelSquires