Skip to content

Remove whitespace stripping of storm queries (SYN-5441) #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added this to the v2.13x.x milestone Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (62107e7) 97.33% compared to head (6b1ee5e) 97.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3175      +/-   ##
==========================================
- Coverage   97.33%   97.24%   -0.10%     
==========================================
  Files         224      224              
  Lines       44797    44787      -10     
==========================================
- Hits        43605    43551      -54     
- Misses       1192     1236      +44     
Flag Coverage Δ
linux 97.24% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormtypes.py 98.77% <ø> (-0.01%) ⬇️
synapse/utils/stormcov/plugin.py 98.71% <ø> (-0.07%) ⬇️
synapse/lib/parser.py 98.51% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added the reqChangelog requires changelog label Jun 8, 2023
@vEpiphyte vEpiphyte requested a review from Cisphyx June 8, 2023 22:22
@invisig0th invisig0th merged commit 94ec6a4 into master Jun 9, 2023
@invisig0th invisig0th deleted the feat_storm_whitespace branch June 9, 2023 10:00
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants