Skip to content

vectToScore updates #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2023

  • More closely emulate the behavior of the NVD calculators over the (non-specific) specification
    • Return overall score
    • Return None for temporal/environmental scores when their respective metrics aren't present
  • Fix for v2 vector edge case

Resolves SYN-5588

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (ce12c9b) 97.33% compared to head (cdcb14d) 97.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3181      +/-   ##
==========================================
- Coverage   97.33%   97.24%   -0.10%     
==========================================
  Files         224      224              
  Lines       44801    44836      +35     
==========================================
- Hits        43609    43600       -9     
- Misses       1192     1236      +44     
Flag Coverage Δ
linux 97.24% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormlib/infosec.py 99.48% <100.00%> (+0.05%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added the reqChangelog requires changelog label Jun 13, 2023
@invisig0th invisig0th merged commit 49d0f00 into master Jun 13, 2023
@invisig0th invisig0th deleted the blackout/SYN-5588/vectToScore-updates branch June 13, 2023 17:39
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants