Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcrpy dep to include 4.4.0 #3204

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

captainGeech42
Copy link
Contributor

The latest version of vcrpy includes the vcrpy-unittest code (which has since been archived) directly, which provides a mixin for unittest which would make using vcrpy in power-up test code simpler, without having to depend on a deprecated package.

@vEpiphyte
Copy link
Contributor

vEpiphyte commented Jun 29, 2023

@captainGeech42 This feature came in from kevin1024/vcrpy#712 and it actually went out in vcrpy 4.4.0. It is easier to update the allowed minor version than the maximum version. vcrpy 5.0.0 has a noted breaking change that needs to be evaluated before it can be allowed in the mainline requirements. See the changelog here https://vcrpy.readthedocs.io/en/latest/changelog.html

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (f87b4af) 97.31% compared to head (55cee9a) 97.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3204      +/-   ##
==========================================
- Coverage   97.31%   97.20%   -0.11%     
==========================================
  Files         226      226              
  Lines       45232    45232              
==========================================
- Hits        44016    43970      -46     
- Misses       1216     1262      +46     
Flag Coverage Δ
linux 97.20% <ø> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@captainGeech42
Copy link
Contributor Author

@vEpiphyte thanks for flagging that, I should've checked the changelog for that release. Updated the deps to <5.0.0

@captainGeech42 captainGeech42 changed the title Update vcrpy dep to 5.0.0 Update vcrpy dep to include 4.4.0 Jun 29, 2023
@vEpiphyte vEpiphyte added this to the v2.1xx.x milestone Jun 29, 2023
Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also have to update the pyproject.toml file.

@vEpiphyte
Copy link
Contributor

@captainGeech42 Can you update this to be vcrpy>=4.3.1,<5.1.0 ?

@vEpiphyte vEpiphyte modified the milestones: v2.141.0, v2.14x.x Jul 7, 2023
@captainGeech42 captainGeech42 requested a review from vEpiphyte July 12, 2023 15:31
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Jul 19, 2023
@vEpiphyte vEpiphyte added reqChangelog requires changelog enhancement labels Jul 21, 2023
@vEpiphyte vEpiphyte merged commit 3396c8b into vertexproject:master Jul 21, 2023
@captainGeech42 captainGeech42 deleted the vcrpy-bump branch July 25, 2023 14:19
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants