-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vcrpy dep to include 4.4.0 #3204
Conversation
@captainGeech42 This feature came in from kevin1024/vcrpy#712 and it actually went out in vcrpy 4.4.0. It is easier to update the allowed minor version than the maximum version. vcrpy 5.0.0 has a noted breaking change that needs to be evaluated before it can be allowed in the mainline requirements. See the changelog here https://vcrpy.readthedocs.io/en/latest/changelog.html |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3204 +/- ##
==========================================
- Coverage 97.31% 97.20% -0.11%
==========================================
Files 226 226
Lines 45232 45232
==========================================
- Hits 44016 43970 -46
- Misses 1216 1262 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@vEpiphyte thanks for flagging that, I should've checked the changelog for that release. Updated the deps to <5.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also have to update the pyproject.toml
file.
@captainGeech42 Can you update this to be |
The latest version of vcrpy includes the
vcrpy-unittest
code (which has since been archived) directly, which provides a mixin for unittest which would make using vcrpy in power-up test code simpler, without having to depend on a deprecated package.