Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new beholder message to track when a service gets connected, helps resolve OP-2570 #3205

Merged
merged 8 commits into from
Jun 30, 2023

Conversation

rakuy0
Copy link
Contributor

@rakuy0 rakuy0 commented Jun 29, 2023

The svcname field won't be available when the svc:add message goes out unless we get very lucky with a race condition. So adding a new message to indicate when the cortex gets connected to a stormsvc and we get back svcname and svcvers info.

@rakuy0 rakuy0 requested a review from vEpiphyte June 29, 2023 21:12
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (398e9c0) 97.29% compared to head (30c8f8b) 97.19%.

❗ Current head 30c8f8b differs from pull request most recent head 950d607. Consider uploading reports for the commit 950d607 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3205      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.10%     
==========================================
  Files         224      224              
  Lines       44896    44897       +1     
==========================================
- Hits        43681    43639      -42     
- Misses       1215     1258      +43     
Flag Coverage Δ
linux 97.19% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 96.88% <100.00%> (-0.52%) ⬇️
synapse/lib/stormsvc.py 97.14% <100.00%> (+0.04%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a unit test for this to the beholder test

invisig0th
invisig0th previously approved these changes Jun 30, 2023
@vEpiphyte vEpiphyte added this to the v2.140.0 milestone Jun 30, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Jun 30, 2023
@vEpiphyte vEpiphyte merged commit c86afce into master Jun 30, 2023
@rakuy0 rakuy0 deleted the beholder_svcset branch June 30, 2023 16:34
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants