-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new beholder message to track when a service gets connected, helps resolve OP-2570 #3205
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3205 +/- ##
==========================================
- Coverage 97.29% 97.19% -0.10%
==========================================
Files 224 224
Lines 44896 44897 +1
==========================================
- Hits 43681 43639 -42
- Misses 1215 1258 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add a unit test for this to the beholder test
The
svcname
field won't be available when thesvc:add
message goes out unless we get very lucky with a race condition. So adding a new message to indicate when the cortex gets connected to a stormsvc and we get backsvcname
andsvcvers
info.