SYN-5692, SYN-5609: vectToScore returns normalized vector #3211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update vectToScore to return normalized vector - Update CVSS validate function with better errors that return detailed info - Create synapse.lookup.cvss and move a bunch of the CVSS constants into it. - Move CVSS validate function into synapse.lib.chop - Add CVSS normalize function in synapse.lib.chop - Update tests Addresses SYN-5692 and SYN-5609. Prepares for SYN-5701 model updates.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3211 +/- ##
==========================================
- Coverage 97.30% 97.20% -0.11%
==========================================
Files 224 225 +1
Lines 44967 44998 +31
==========================================
- Hits 43757 43740 -17
- Misses 1210 1258 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ghost
commented
Jul 3, 2023
ghost
marked this pull request as ready for review
vEpiphyte
reviewed
Jul 3, 2023
vEpiphyte
reviewed
Jul 3, 2023
vEpiphyte
reviewed
Jul 3, 2023
invisig0th
previously approved these changes
Jul 5, 2023
invisig0th
approved these changes
Jul 5, 2023
ghost
changed the title
vEpiphyte
approved these changes
Jul 6, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses SYN-5692 and SYN-5609. Prepares for SYN-5701 model updates.