Skip to content

Taxonomy regular expression comparator cmpr is busted (SYN-5644) #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 5, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 3, 2023

  • Removed value norming in synapse.lib.types.Type.cmpr method so regex patterns don't get normed to the target type.
  • Add tests to check the regex matching logic.

Fixes SYN-5644

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (dec6ac1) 97.30% compared to head (e97dadc) 97.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
- Coverage   97.30%   97.20%   -0.11%     
==========================================
  Files         224      224              
  Lines       44966    44967       +1     
==========================================
- Hits        43756    43709      -47     
- Misses       1210     1258      +48     
Flag Coverage Δ
linux 97.20% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/types.py 97.63% <100.00%> (+<0.01%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost force-pushed the blackout/SYN-5644 branch from 2ecaaab to 970951d Compare July 5, 2023 13:51
@ghost ghost force-pushed the blackout/SYN-5644 branch from 03c089c to 698abab Compare July 5, 2023 14:59
@ghost ghost requested a review from invisig0th July 5, 2023 16:15
@ghost ghost marked this pull request as ready for review July 5, 2023 20:19
@invisig0th invisig0th merged commit 01e0d18 into master Jul 5, 2023
@invisig0th invisig0th deleted the blackout/SYN-5644 branch July 5, 2023 20:38
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Jul 5, 2023
@vEpiphyte vEpiphyte added this to the v2.1xx.x milestone Jul 5, 2023
@vEpiphyte vEpiphyte added reqChangelog requires changelog and removed reqChangelog requires changelog labels Jul 5, 2023
@vEpiphyte vEpiphyte changed the title Taxonomy regular expression comparator cmpr is busted Taxonomy regular expression comparator cmpr is busted (SYN-5644) Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants