Skip to content

Fix TypeError when passing a Number to $lib.math.number (SYN-5571) #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Jul 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (ce6e1f2) 97.29% compared to head (f8e7d0b) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3215      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.11%     
==========================================
  Files         224      224              
  Lines       44897    44899       +2     
==========================================
- Hits        43683    43639      -44     
- Misses       1214     1260      +46     
Flag Coverage Δ
linux 97.19% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormtypes.py 98.72% <ø> (ø)
synapse/lib/stormlib/math.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.1xx.x milestone Jul 4, 2023
@vEpiphyte vEpiphyte added the bug label Jul 4, 2023
@vEpiphyte vEpiphyte added the reqChangelog requires changelog label Jul 4, 2023
@vEpiphyte vEpiphyte merged commit c82ecac into master Jul 4, 2023
@vEpiphyte vEpiphyte deleted the number-bugfix branch July 4, 2023 17:13
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants