Prevent yield from operating on nodes which did not come from the current view. (SYN-5679)

[vEpiphyte]

No description provided.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (b43baff) 97.31% compared to head (a04dcf4) 97.20%.

❗ Current head a04dcf4 differs from pull request most recent head 46c4298. Consider uploading reports for the commit 46c4298 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
- Coverage   97.31%   97.20%   -0.11%     
==========================================
  Files         225      225              
  Lines       44998    45005       +7     
==========================================
- Hits        43788    43747      -41     
- Misses       1210     1258      +48     

Flag	Coverage Δ
linux	97.20% <100.00%> (-0.01%)	⬇️
linux_replay	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
synapse/lib/ast.py	98.93% <100.00%> (+<0.01%)	⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Cisphyx]

I think we might need to check the view in the if isinstance(valu, s_stormtypes.Prim): case as well, I think you could potentially sneak through nodes in an embedquery there.

[Cisphyx]

An embedquery will still allow nodes from other views through:
view.exec 4aaedfd7ce26c9617f623e0b73c85f79 { $x=${it:dev:str=foo } } | yield $x