SYN-5600: Removing extended form does not properly remove all the props #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3223 +/- ##
==========================================
- Coverage 97.27% 97.19% -0.09%
==========================================
Files 225 225
Lines 45049 45054 +5
==========================================
- Hits 43823 43791 -32
- Misses 1226 1263 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ghost
changed the title
ghost
marked this pull request as ready for review
vEpiphyte
reviewed
Jul 8, 2023
vEpiphyte
reviewed
Jul 8, 2023
vEpiphyte
requested changes
Jul 8, 2023
vEpiphyte
approved these changes
Jul 11, 2023
invisig0th
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synapse.datamodel.Model.delForm()to check for extended properties on the form before deletion. If extended props are found, raise exception with names of properties.Resolves SYN-5600