SYN-5701: CVSS norm doesn't handle unordered vectors #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update risk model so risk:vuln:cvss:v2 and :cvss:v3 props are proper types that can do normalization and validation of values - Added migration model to synapse-regression repo - Updated tests Resolves SYN-5701
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3224 +/- ##
==========================================
- Coverage 97.30% 97.19% -0.11%
==========================================
Files 225 225
Lines 45014 45036 +22
==========================================
- Hits 43799 43771 -28
- Misses 1215 1265 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ghost
marked this pull request as ready for review
ghost
changed the title
vEpiphyte
reviewed
Jul 8, 2023
vEpiphyte
reviewed
Jul 10, 2023
vEpiphyte
reviewed
Jul 10, 2023
…exproject/synapse into blackout/SYN-5701/cvss-model-update
invisig0th
previously approved these changes
Jul 11, 2023
vEpiphyte
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SYN-5701