Skip to content

SYN-5736: storm support for octal constants #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2023

  • Add octal regex and plumb to appropriate locations
  • Update NUMBER, HEXNUMBER and OCTNUMBER regexes with multi-line and comments for easier reading

Resolves SYN-5736

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (e11a461) 97.29% compared to head (4f59e12) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3231      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.11%     
==========================================
  Files         225      225              
  Lines       45054    45054              
==========================================
- Hits        43837    43791      -46     
- Misses       1217     1263      +46     
Flag Coverage Δ
linux 97.19% <ø> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/parser.py 98.51% <ø> (ø)
synapse/lib/storm_format.py 100.00% <ø> (ø)
synapse/utils/stormcov/plugin.py 98.71% <ø> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost changed the title WIP SYN-5736: storm support for octal constants SYN-5736: storm support for octal constants Jul 12, 2023
@ghost ghost marked this pull request as ready for review July 12, 2023 14:20
@ghost ghost requested review from invisig0th and Cisphyx July 12, 2023 14:20
@invisig0th invisig0th merged commit 60fe120 into master Jul 12, 2023
@invisig0th invisig0th deleted the blackout/SYN-5736/octal-constants branch July 12, 2023 15:00
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Jul 12, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Jul 12, 2023
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants