Skip to content

Always toprim Storm Dict keys (SYN-5288) #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Conversation

mikemoritz
Copy link
Contributor

  • Also checks that the key is not mutable

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (361ac02) 97.30% compared to head (a5bbc39) 97.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3233      +/-   ##
==========================================
- Coverage   97.30%   97.20%   -0.11%     
==========================================
  Files         226      226              
  Lines       45152    45174      +22     
==========================================
- Hits        43936    43912      -24     
- Misses       1216     1262      +46     
Flag Coverage Δ
linux 97.20% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/ast.py 98.93% <100.00%> (+<0.01%) ⬆️
synapse/lib/stormtypes.py 98.73% <100.00%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mikemoritz mikemoritz merged commit 024d9f0 into master Jul 17, 2023
@mikemoritz mikemoritz deleted the redox-dict-deref branch July 17, 2023 15:31
@vEpiphyte vEpiphyte added this to the v2.142.0 milestone Jul 17, 2023
@vEpiphyte vEpiphyte added reqChangelog requires changelog and removed reqChangelog requires changelog labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants