Skip to content

SYN-5780: inet:ipv4 scrape finds hollywood IP addresses #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2023

  • Update ipv4 regex to exclude matches with extra digits at the beginning/end or which are dotted number sequences longer than 4
  • Update test

Resolves SYN-5780

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (ddda6a9) 97.30% compared to head (55c3c17) 97.19%.

❗ Current head 55c3c17 differs from pull request most recent head 28223a7. Consider uploading reports for the commit 28223a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
- Coverage   97.30%   97.19%   -0.11%     
==========================================
  Files         225      225              
  Lines       45073    45054      -19     
==========================================
- Hits        43857    43789      -68     
- Misses       1216     1265      +49     
Flag Coverage Δ
linux 97.19% <ø> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/scrape.py 99.30% <ø> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost changed the title WIP SYN-5780: inet:ipv4 scrape finds hollywood IP addresses SYN-5780: inet:ipv4 scrape finds hollywood IP addresses Jul 13, 2023
@ghost ghost marked this pull request as ready for review July 13, 2023 14:25
@ghost ghost requested a review from vEpiphyte July 13, 2023 14:28
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Jul 13, 2023
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog and removed enhancement labels Jul 13, 2023
@vEpiphyte vEpiphyte merged commit e095445 into master Jul 13, 2023
@vEpiphyte vEpiphyte deleted the blackout/SYN-5780/hollywood-ip-addrs branch July 13, 2023 17:45
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants