Skip to content

SYN-5749: AttributeError type error with getting deprecated property #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2023

  • Added type checks for the appropriate modelext functions
  • Added new test to validate type checking

Resolves SYN-5749

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (024d9f0) 97.30% compared to head (b83c061) 97.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3243      +/-   ##
==========================================
- Coverage   97.30%   97.20%   -0.11%     
==========================================
  Files         226      226              
  Lines       45174    45198      +24     
==========================================
- Hits        43958    43936      -22     
- Misses       1216     1262      +46     
Flag Coverage Δ
linux 97.20% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 96.92% <100.00%> (-0.49%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost changed the title WIP SYN-5749: AttributeError type error with getting deprecated property SYN-5749: AttributeError type error with getting deprecated property Jul 17, 2023
@ghost ghost marked this pull request as ready for review July 17, 2023 13:09
@ghost ghost requested a review from invisig0th July 17, 2023 13:12
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Jul 17, 2023
@vEpiphyte vEpiphyte added this to the v2.142.0 milestone Jul 17, 2023
@vEpiphyte vEpiphyte merged commit 5b00294 into master Jul 17, 2023
@vEpiphyte vEpiphyte deleted the blackout/SYN-5749/type-errors branch July 17, 2023 19:31
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants