Skip to content

SYN-5725: cortex user limit option (does not count root) #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9 commits merged into from
Jul 18, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2023

  • Add config options to synapse.lib.hiveauth.Auth
  • Plumb auth:conf cell options into auth
  • Check for maxusers in Auth.addUser()
  • Add tests

Resolves SYN-5725

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (e56940f) 97.31% compared to head (0ee9c14) 97.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3244      +/-   ##
==========================================
- Coverage   97.31%   97.20%   -0.11%     
==========================================
  Files         226      226              
  Lines       45227    45232       +5     
==========================================
- Hits        44011    43970      -41     
- Misses       1216     1262      +46     
Flag Coverage Δ
linux 97.20% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/cell.py 98.00% <100.00%> (+<0.01%) ⬆️
synapse/lib/hiveauth.py 96.69% <100.00%> (-0.44%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost changed the title WIP SYN-5725: cortex user limit option (does not count root) SYN-5725: cortex user limit option (does not count root) Jul 17, 2023
@ghost ghost marked this pull request as ready for review July 17, 2023 13:12
@ghost ghost requested a review from invisig0th July 17, 2023 13:12
@ghost ghost requested a review from vEpiphyte July 17, 2023 16:18
invisig0th
invisig0th previously approved these changes Jul 17, 2023
@vEpiphyte vEpiphyte added this to the v2.142.0 milestone Jul 17, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Jul 17, 2023
@ghost ghost requested review from vEpiphyte and invisig0th July 17, 2023 19:42
@ghost ghost merged commit 4acd7cb into master Jul 18, 2023
@ghost ghost deleted the blackout/SYN-5725/user-limit branch July 18, 2023 13:10
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 18, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants