Skip to content

Prevent emitter functions from leaving sub-runtimes behind (SYN-5819) #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 25, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Jul 20, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (300177a) 97.31% compared to head (6f06301) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3250      +/-   ##
==========================================
- Coverage   97.31%   97.21%   -0.11%     
==========================================
  Files         226      226              
  Lines       45356    45359       +3     
==========================================
- Hits        44140    44095      -45     
- Misses       1216     1264      +48     
Flag Coverage Δ
linux 97.21% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/ast.py 98.93% <100.00%> (+<0.01%) ⬆️
synapse/lib/coro.py 97.67% <100.00%> (+0.02%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cisphyx Cisphyx changed the title Fini sub-runtimes when parent runtime is fini'd (SYN-5819) Prevent emitter functions from leaving sub-runtimes behind (SYN-5819) Jul 20, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Jul 21, 2023
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Jul 21, 2023
@Cisphyx Cisphyx merged commit ef5f050 into master Jul 25, 2023
@Cisphyx Cisphyx deleted the fini-emitters branch July 25, 2023 13:11
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants