SYN-5750: storm text being None when hashing

[ghost]

• Add check in synapse.lib.view.storm for storm text being None and raise s_exc.BadArg
• Add test
  Resolves SYN-5750

I could not figure out how to repro this from either the storm CLI or Optic. The best solution I could come up with is to raise s_exc.BadArg if storm text is None so at least the python exception doesn't leak into the storm runtime. I think it should also be nicely handled by Optic.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (27abbf5) 97.31% compared to head (a04a843) 97.21%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3255      +/-   ##
==========================================
- Coverage   97.31%   97.21%   -0.11%     
==========================================
  Files         226      226              
  Lines       45350    45353       +3     
==========================================
- Hits        44134    44091      -43     
- Misses       1216     1262      +46     

Flag	Coverage Δ
linux	97.21% <100.00%> (+<0.01%)	⬆️
linux_replay	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
synapse/lib/view.py	97.10% <100.00%> (-0.31%)	⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.