Skip to content

SYN-5418: scrape support for finding ipv6 addresses #3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2023

  • Added IPv6 regexes to synapse.lib.scrape
  • Updated inet:server regex to support IPV6 [addr]:port patterns
  • Updated scrape tests with good and bad inet:ipv6 and inet:server examples

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (9f97344) 97.31% compared to head (5e9382d) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3259      +/-   ##
==========================================
- Coverage   97.31%   97.21%   -0.10%     
==========================================
  Files         226      226              
  Lines       45374    45383       +9     
==========================================
- Hits        44156    44121      -35     
- Misses       1218     1262      +44     
Flag Coverage Δ
linux 97.21% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/scrape.py 99.34% <100.00%> (+0.04%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost changed the title WIP SYN-5418: scrape support for finding ipv6 addresses SYN-5418: scrape support for finding ipv6 addresses Jul 24, 2023
@ghost ghost marked this pull request as ready for review July 24, 2023 18:21
@ghost ghost requested review from vEpiphyte and Cisphyx July 24, 2023 18:21
invisig0th
invisig0th previously approved these changes Jul 25, 2023
@ghost ghost requested review from invisig0th and vEpiphyte July 25, 2023 15:33
@invisig0th invisig0th merged commit 503086b into master Jul 25, 2023
@invisig0th invisig0th deleted the blackout/SYN-5418/scrape-ipv6 branch July 25, 2023 16:40
@vEpiphyte vEpiphyte added this to the v2.143.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants