SYN-5719: Update deprecated property warning to only log once #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jul 25, 2023
ghost
commented
- Changed log message to include the count of detected properties
- Updated tests to check for new behavior
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3264 +/- ##
==========================================
- Coverage 97.32% 97.21% -0.11%
==========================================
Files 226 226
Lines 45383 45386 +3
==========================================
- Hits 44167 44122 -45
- Misses 1216 1264 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ghost
requested review from
invisig0th
approved these changes
Jul 25, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.