Skip to content

Check for not string instead of None #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

MichaelSquires
Copy link
Contributor

  • Instead of checking for None, validate the incoming storm text is a str type.

Updates SYN-5750

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (e566ed9) 97.32% compared to head (d17a5c9) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3269      +/-   ##
==========================================
- Coverage   97.32%   97.21%   -0.11%     
==========================================
  Files         227      227              
  Lines       45430    45430              
==========================================
- Hits        44214    44166      -48     
- Misses       1216     1264      +48     
Flag Coverage Δ
linux 97.21% <100.00%> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/view.py 97.10% <100.00%> (-0.33%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte added this to the v2.143.0 milestone Jul 27, 2023
@vEpiphyte vEpiphyte added the bug label Jul 27, 2023
@MichaelSquires MichaelSquires merged commit 3d8b2bd into master Jul 27, 2023
@MichaelSquires MichaelSquires deleted the blackout/SYN-5750/update-storm-type-check branch July 27, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants