Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storm keepalives (SYN-5874) #3272

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Add Storm keepalives (SYN-5874) #3272

merged 5 commits into from
Aug 1, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (3b696fb) 97.32% compared to head (58ab252) 97.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
- Coverage   97.32%   97.22%   -0.11%     
==========================================
  Files         227      227              
  Lines       45429    45437       +8     
==========================================
- Hits        44213    44175      -38     
- Misses       1216     1262      +46     
Flag Coverage Δ
linux 97.22% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/snap.py 96.04% <100.00%> (+0.01%) ⬆️
synapse/lib/view.py 97.12% <100.00%> (-0.30%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte marked this pull request as ready for review July 28, 2023 19:24
@vEpiphyte vEpiphyte changed the title Add Storm keepalives Add Storm keepalives (SYN-5874) Jul 28, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Jul 28, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Jul 28, 2023
@vEpiphyte vEpiphyte requested a review from invisig0th July 31, 2023 14:19
@invisig0th invisig0th merged commit 9cee43e into master Aug 1, 2023
@invisig0th invisig0th deleted the feat_storm_keepalives branch August 1, 2023 14:08
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants