Skip to content

SYN-5812: storm dmons to start AFTER model migrations #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MichaelSquires
Copy link
Contributor

@MichaelSquires MichaelSquires commented Jul 31, 2023

  • Move storm dmon init to be after model migration
  • Add new tests to verify desired startup behavior

Resolves SYN-5812

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.12% ⚠️

Comparison is base (9cee43e) 97.32% compared to head (c4471bb) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3279      +/-   ##
==========================================
- Coverage   97.32%   97.21%   -0.12%     
==========================================
  Files         227      227              
  Lines       45437    45437              
==========================================
- Hits        44221    44170      -51     
- Misses       1216     1267      +51     
Flag Coverage Δ
linux 97.21% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/cortex.py 97.00% <100.00%> (-0.50%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

invisig0th
invisig0th previously approved these changes Jul 31, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Aug 1, 2023
@vEpiphyte vEpiphyte added the bug label Aug 1, 2023
vEpiphyte
vEpiphyte previously approved these changes Aug 1, 2023
@MichaelSquires MichaelSquires dismissed stale reviews from vEpiphyte and invisig0th via c4471bb August 1, 2023 14:31
@MichaelSquires MichaelSquires marked this pull request as ready for review August 1, 2023 14:31
@MichaelSquires MichaelSquires changed the title WIP SYN-5812: storm dmons to start AFTER model migrations SYN-5812: storm dmons to start AFTER model migrations Aug 1, 2023
@MichaelSquires MichaelSquires merged commit 06a21aa into master Aug 2, 2023
@MichaelSquires MichaelSquires deleted the blackout/SYN-5812/storm-dmons-start-after-model-migrations branch August 2, 2023 14:31
@vEpiphyte vEpiphyte added reqChangelog requires changelog and removed reqChangelog requires changelog labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants