SYN-5870: optional user count limits to account for locked/archived users #3295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MichaelSquires
commented
Aug 16, 2023
MichaelSquires
commented
- Update code to account for locked/archived users
- Update test
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3295 +/- ##
==========================================
- Coverage 97.31% 97.21% -0.11%
==========================================
Files 227 227
Lines 45469 45483 +14
==========================================
- Hits 44250 44216 -34
- Misses 1219 1267 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MichaelSquires
changed the title
Cisphyx
reviewed
Aug 16, 2023
Cisphyx
previously approved these changes
Aug 16, 2023
vEpiphyte
reviewed
Aug 16, 2023
vEpiphyte
approved these changes
Aug 17, 2023
invisig0th
approved these changes
Aug 17, 2023
invisig0th
deleted the
blackout/SYN-5870/user-count-checks-archived-locked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.