Skip to content

Tweak s_common.wait_for implementation #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 23, 2023
Merged

Tweak s_common.wait_for implementation #3307

merged 7 commits into from
Aug 23, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Aug 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (778b1e6) 97.25% compared to head (f8196be) 97.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3307      +/-   ##
==========================================
- Coverage   97.25%   97.16%   -0.10%     
==========================================
  Files         228      228              
  Lines       45655    45675      +20     
==========================================
- Hits        44403    44380      -23     
- Misses       1252     1295      +43     
Flag Coverage Δ
linux 97.16% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/common.py 98.36% <100.00%> (+0.06%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

invisig0th
invisig0th previously approved these changes Aug 22, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Aug 22, 2023
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Aug 22, 2023
@Cisphyx Cisphyx merged commit a2ca678 into master Aug 23, 2023
@Cisphyx Cisphyx deleted the tweak-waitfor branch August 23, 2023 13:21
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants