Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify IPv6 scrape regex and validate matches (SYN-6006) #3311

Merged
merged 14 commits into from
Aug 25, 2023
Merged

Simplify IPv6 scrape regex and validate matches (SYN-6006) #3311

merged 14 commits into from
Aug 25, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Aug 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (81fba1d) 97.28% compared to head (eaf3ba4) 97.18%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
- Coverage   97.28%   97.18%   -0.10%     
==========================================
  Files         228      228              
  Lines       45844    45863      +19     
==========================================
- Hits        44601    44574      -27     
- Misses       1243     1289      +46
Flag Coverage Δ
linux 97.18% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/scrape.py 99.41% <100.00%> (+0.07%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cisphyx Cisphyx changed the title WIP: Simplify IPv6 scrape regex and validate matches (SYN-6006) Simplify IPv6 scrape regex and validate matches (SYN-6006) Aug 24, 2023
Cisphyx
Cisphyx commented Aug 24, 2023
View reviewed changes
Copy link
Contributor Author

@Cisphyx Cisphyx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reduces the time to scrape the 24MB chrome crux 1million file with ptype=inet:ipv6 from ~210sec to ~16sec (from testing on my local machine).

@Cisphyx Cisphyx changed the title Simplify IPv6 scrape regex and validate matches (SYN-6006) WIP: Simplify IPv6 scrape regex and validate matches (SYN-6006) Aug 24, 2023
@Cisphyx Cisphyx changed the title WIP: Simplify IPv6 scrape regex and validate matches (SYN-6006) Simplify IPv6 scrape regex and validate matches (SYN-6006) Aug 24, 2023
@vEpiphyte vEpiphyte added this to the v2.145.0 milestone Aug 25, 2023
@vEpiphyte vEpiphyte added the bug label Aug 25, 2023
@invisig0th invisig0th merged commit a4c92a7 into master Aug 25, 2023
@invisig0th invisig0th deleted the ipv6-scrape-simplify branch August 25, 2023 13:59
@vEpiphyte vEpiphyte added reqChangelog requires changelog and removed reqChangelog requires changelog labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invisig0th invisig0th invisig0th approved these changes

@vEpiphyte vEpiphyte vEpiphyte approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.145.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Cisphyx @invisig0th @vEpiphyte